BiglySoftware / BiglyBT

Feature-filled Bittorrent client based on the Azureus open source project
https://www.biglybt.com
GNU General Public License v2.0
1.58k stars 152 forks source link

[question] is there any change on focus of panel in library view between 1.9 and 2.2? #1512

Closed SUCM closed 4 years ago

SUCM commented 4 years ago

on many versions of Vuze and Bigly 1.x, I'm used to having focus default to seeding panel in library view when

  1. nothing is selected in the downloading panel
  2. the latest selected torrent is a seeding torrent

where, I usually just use CTRL+A and hotkey to stop/pause seeding torrents for recheck/hash

However, the focus behaviour changed after I updated straight from Bigly 1.x to Bigly 2.2. now if I don't explicitly select a seeding torrent and wait for selection to draw, CTRL+A can select all downloading torrents and stopped all download torrents to re-check/hash on these incomplete torrents because I usually quickly press the hotkeys

this has been quite inconvenient, so I'm just wondering if it's a known/intentional code change or side effect of something else

parg commented 4 years ago

Looks like a bug, thanks :)

SUCM commented 4 years ago

would like to confirm if fix is not in 2.3.0.0 or fix is not complete in 2.3.0.0

parg commented 4 years ago

You saying it isn't fixed?

SUCM commented 4 years ago

on 2.3.0.0, not sure if it's just me. occurrence reduced, but still happens from time to time

reproducing steps is roughly like the following. hopefully no missing details/steps

  1. CTRL+A select all on torrents in seeding panel (some stopped due to reach ratio or no downloader, some still active, some queued)
  2. do whatever with the selected seeding torrents (right click recheck hash, hotkey to tag or stop...etc)
  3. add new torrents where each has its own prompt
  4. additional torrents finished download and jumped to seeding panel while doing step 3
  5. add all of the new torrents from step3 to download panel by clicking their ok buttons one by one
  6. after all new torrents prompt are handled, focus goes back to step1's selected torrents
  7. press hotkey to remove seeding torrents and immediately press CTRL+A
  8. I expect the newly seeding torrents from step4 to be selected since focus was on the torrents in seeding panel, but sometimes all downloading torrents become selected on 2.3.0.0
parg commented 4 years ago

Hmm, there may well still be a bug there :( Not high on my list though I'm afraid

SUCM commented 4 years ago

that's why I wanted to confirm if this issue was fixed in 2.3.0.0

parg commented 4 years ago

well partially it was, your original scenario should be fixed

SUCM commented 4 years ago

well, this is the original scenario where step7-8 cover the original scenario1&2. I generalized it into the original scenario1&2 since those were very common and I suspected some timing was in the play

anyways. was just interested to know if I should watch this issue or some other (existing?) issue for the more complete fix

SUCM commented 4 years ago

sometimes when I had already click on a seeding torrent and it's highlighted/selected, CTRL-A would still select all torrents in the download panel