search

Bigous / ng2-highcharts

Angular2 library to use Highcharts out of the box
59 stars 23 forks source link

quick question... #4

Closed born2net closed 8 years ago

born2net commented 8 years ago

I like your project, found it useful in a new project I am working on. I may add it to my Angular2 app, check it out: http://ng2.javascriptninja.io

question, why did you apply today's changes with jquery? https://github.com/Bigous/ng2-highcharts/commit/cbaefb918bdf76d0d305efaa7cc6bad7bb3c0ab9

what bug did this solve?

just wondering

regards

Sean

Bigous commented 8 years ago

Hi @born2net.

I may add it to my Angular2 app, check it out: http://ng2.javascriptninja.io

Sure!

question, why did you apply today's changes with jquery?

Highcharts 4.2.1 no longer exists without JQuery - all their examples are migrating to JQuery too. But I was avoiding using JQuery (and still am) where it's not necessary. The correct answer is, I want to delivery a version of the library with Maps and Stock directives so people can start using it. Propably I'll refactory it latter so I can remove my JQuery dependency (but Highcharts itself depends on it after version 4.2.x)

what bug did this solve?

No bugs soved. Just implementation of Stocks and Maps (sort of... because the first release of Stock and Maps were not working without it... function definition, etc... but I'll refactor it later)

born2net commented 8 years ago

Got it! tx... I to ended up using jQuery for some things.. hard to avoid :) even in ng2