Bihaqo / t3f

Tensor Train decomposition on TensorFlow
https://t3f.readthedocs.io/en/latest/index.html
MIT License
219 stars 55 forks source link

Added tests for checking composite ranks #142

Closed lokhande-vishnu closed 5 years ago

lokhande-vishnu commented 6 years ago

Did you find a reason for poor reconstruction error despite setting max_tt_ranks to a high number? This was put as a To-Do under "testTTMatrix" in t3f/decompositions_test.py (line 77 before commit)

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.05%) to 93.581% when pulling ec60f0345fd629049175523a36b30a7dbf790618 on lokhande-vishnu:develop into c7bb692f14906f8b7520a23d60ff70f89a9f9859 on Bihaqo:develop.

Bihaqo commented 5 years ago

Thank you so much and sorry for such a long reply, it's brilliant now!