search

Bihaqo / t3f

Tensor Train decomposition on TensorFlow
https://t3f.readthedocs.io/en/latest/index.html
MIT License
218 stars 56 forks source link

Full tf2 support #201

Closed Bihaqo closed 4 years ago

faysou commented 4 years ago

Hi Alexander, what's the reason for not merging pull requests ?

Bihaqo commented 4 years ago

I can't quite make tests to run. I created this issue for the nose which I use for running tests, but they are not actively maintaining the code I guess: https://github.com/nose-devs/nose/issues/1101

On Mon, 10 Feb 2020 at 07:12, faysou notifications@github.com wrote:

Hi Alexander, what's the reason for not merging pull requests ?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Bihaqo/t3f/pull/201?email_source=notifications&email_token=ABK6V2JAFZHKW22WT3B5BO3RCD467A5CNFSM4J3SEFPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOELHOWWA#issuecomment-583986008, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK6V2OLDFU675HINYSS65TRCD467ANCNFSM4J3SEFPA .

faysou commented 4 years ago

Ah ok. I thought that given it's your repository it wouldn't be an issue.

coveralls commented 4 years ago

Coverage Status

Coverage decreased (-0.5%) to 93.336% when pulling 450ecfc47053a0cabc411b292f3cae7fc16fc724 on full_tf2_support into 0ce4d12bd28451cb6093719da5535824d15d4e3a on develop.

faysou commented 4 years ago

Nice work !

Bihaqo commented 4 years ago

Thanks :)

On Tue, 25 Feb 2020 at 00:08, faysou notifications@github.com wrote:

Nice work !

— You are receiving this because you modified the open/close state.

Reply to this email directly, view it on GitHub https://github.com/Bihaqo/t3f/pull/201?email_source=notifications&email_token=ABK6V2JJXTGSNKCH5FHUCXLREROPVA5CNFSM4J3SEFPKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEM2ARCA#issuecomment-590612616, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABK6V2OWWALVRT4BXHBADYTREROPVANCNFSM4J3SEFPA .

faysou commented 4 years ago

I wonder if your library will be used by more people at some point because it can be really useful for compressing matrices in neural networks. At least by keeping it up to date we will know.