search

BijoySingh / Scarlet-Notes

[Discontinued and Unsupported Project] Simple yet powerful rich note taking android application, with a lot of flexibilty of usage
https://play.google.com/store/apps/details?id=com.bijoysingh.quicknote
GNU General Public License v3.0
354 stars 94 forks source link

Hide some bottom toolbar actions in certain contexts #140

Closed Fs00 closed 4 years ago

Fs00 commented 4 years ago

I've started to fix some of the inconsistencies mentioned in #121. With this PR, create folder button is hidden when inside a folder (since nested folders are not possible) and all action buttons (create folder/note) are hidden when displaying deleted notes (trash). If you're okay with it, I would also move the button for deleting notes permanently (which is currently in the pre-bottom toolbar) to the bottom toolbar, since as it is now it doesn't seem clickable at a first glance and the bottom right corner seems the perfect place for it.

BijoySingh commented 4 years ago

@Fs00 Thanks for the pull request! Really appreciate it. Added some comments.

Fs00 commented 4 years ago

The bottom bar is already dependent on the navigation context to some degree, e.g. when you click the "create note" button inside a folder. The behavior of that button should also be aware of whether the user is in archive, protected or favourite view, which currently isn't (this is something I want to address in a future PR). But when the user is viewing the trash, why would they add a note or a folder that is already marked for permanent deletion? At this moment the "create note" button behavior is confusing for the latter reason and also because the note is saved in a context different from the one where the user started the action. Whether buttons should be disabled or removed isn't really important, though I'd prefer not to see 3 disabled buttons in a row and use that space for the only meaningful action that can be done inside trash - permanent deletion (removing that action from the auto-deletion notice). In any case, I leave the decision to you.

Fs00 commented 4 years ago

I'm not against disabling buttons per se instead of removing them, but, as you can see in the screenshot below, I do believe that trash UI needs some changes.

scarlet_overlapping_buttons

The "pending backup" notification overlaps the button to empty the trash, which, as I've already said, doesn't really seem clickable at a first glance (I myself have discovered it by chance). I think that putting that button in the main bar in place of the other ones not only makes more clear its intent, but also enforces the fact that the current context (trash) is different from all the others.

@BijoySingh Let me know what are your opinions so that I can make the necessary changes to get this PR merged sooner or later.