BijoySingh / Scarlet-Notes

[Discontinued and Unsupported Project] Simple yet powerful rich note taking android application, with a lot of flexibilty of usage
https://play.google.com/store/apps/details?id=com.bijoysingh.quicknote
GNU General Public License v3.0
354 stars 94 forks source link

Notes are not deleted after X days from trash #151

Open AndhikaWB opened 4 years ago

AndhikaWB commented 4 years ago

Notes (in Trash) are not getting deleted automatically, they stay forever in my Google Drive storage.

My guess is that the (new) introduced sync feature does not check for date of notes. It will sync from cloud if notes don't exist on local storage (especially on a clean install of Scarlet Notes) and will make the date of old notes got renewed again and again.

I'm not sure about notes that are deleted permanently (without going through Trash) but I hope they are deleted from my Google Drive for real.

BijoySingh commented 4 years ago

Ah, that is an interesting bug.

I wasn't able to reproduce this exactly. But I am adding some additional logic to delete notes. Could it be you are using multiple devices which have different times / timezones, that can cause such weird issues.

BijoySingh commented 4 years ago

caf50641

AndhikaWB commented 4 years ago

I'm just using one device. I recently flashed a custom ROM so all my data are lost and I reinstalled Scarlet Notes (Pro).

Then I started to notice that old (deleted) notes are appearing on Scarlet Notes home screen (after syncing) for few seconds before disappearing again. Because of that, I checked my trash and noticed that my old notes in trash are not getting deleted automatically after X days (I'm quite sure some of them are already in trash long ago before I even flashed the custom ROM).

Today, I do a cross check on my Google Drive and indeed, all my old (deleted) notes are inside the Scarlet (App Data) -> notes, they are not truly deleted. Although they also don't appear on my Scarlet Notes for now (except on the first sync that I stated before).

So there are 2 guess:

Please take a note that I haven't tried deleting notes in trash manually. They may have a different behavior on a clean install of Scarlet Notes (they may/may not appear again).