search

BijoySingh / Scarlet-Notes

[Discontinued and Unsupported Project] Simple yet powerful rich note taking android application, with a lot of flexibilty of usage
https://play.google.com/store/apps/details?id=com.bijoysingh.quicknote
GNU General Public License v3.0
354 stars 94 forks source link

Hide/disable bottom toolbar actions in certain contexts #168

Closed Fs00 closed 1 year ago

Fs00 commented 4 years ago

This PR aims to accomplish what #140 tried to do, with some changes based on the feedback received. Now the button to create a folder is disabled when inside a folder (and not hidden anymore), while in Trash section all buttons are replaced with a single action to delete permanently all notes (which has been moved down from the trash notice toolbar, since IMHO its intent wasn't clear enough in that place).

Here's a screencast showcasing the changes: https://streamable.com/5i3qe

About the argument of the independence of the toolbar from the content of the screen, which was brought up in the previous PR, here's a quote directly from the Material Design guidelines:

To support the intent of different sections of an app, the layout and actions of a bottom app bar can be changed to suit each screen.

I think this a perfect case where bottom bar actions should change, since none of the other three apply to the context of the trash (and therefore are confusing for the user).

Fs00 commented 3 years ago

@BijoySingh Is there any chance that my PRs will get merged? Can we consider Scarlet an abandoned project?

Fs00 commented 1 year ago

Merged in my personal fork.