Bilal-S / iis2tomcat

AJP Connector between Internet Information Services (IIS) and Apache Tomcat
http://www.boncode.net/boncode-connector
49 stars 32 forks source link

Fix for #14. Empty request headers causing connection to fail #15

Closed DominicWatson closed 10 years ago

DominicWatson commented 10 years ago

Fixed by detecting NULL headers and setting their values to an empty string, rather than NULL

DominicWatson commented 10 years ago

The fix exists in its own branch, bugfix-14. I've not merged in pull requests this way but I presume you would need to accept the pull request and then merge the bugfix-14 branch into master.

Bilal-S commented 10 years ago

I meant to say: You da man!

On Fri, Dec 20, 2013 at 8:54 AM, Dominic Watson notifications@github.comwrote:

Fixed by detecting NULL headers and setting their values to an empty

string, rather than NULL

You can merge this Pull Request by running

git pull https://github.com/DominicWatson/iis2tomcat bugfix-14

Or view, comment on, or merge it at:

https://github.com/Bilal-S/iis2tomcat/pull/15 Commit Summary

  • Fix for #14. Empty request headers causing connection to fail

File Changes

  • M BonCodeAJP13/ServerPackets/BonCodeAJP13ForwardRequest.cshttps://github.com/Bilal-S/iis2tomcat/pull/15/files#diff-0(16)

Patch Links:

DominicWatson commented 10 years ago

Sweet. Gotta love how easy GitHub makes contributing :)