search

BilalShahid13 / PersistentBottomNavBar

A highly customizable persistent bottom navigation bar for Flutter
BSD 3-Clause "New" or "Revised" License
507 stars 371 forks source link

Fixed onWillPop assert error #309

Open yu1ro opened 1 year ago

yu1ro commented 1 year ago

fix #308

ayoubm commented 1 year ago

@BilalShahid13 can you please merge this PR? It's needed for the willPopScope to work properly.

Thank you!

pishguy commented 1 year ago

@yu1ro +1

htunlin-kitesense commented 1 year ago

Hello, can help merge this PR? willPopScope not working properly in PersistentTabView.custom.

danielcabral-code commented 1 year ago

Hey, would be nice if someone could merge this please. As @htunlin-kitesense mentioned, PersistentTabView.custom is currently impossible to use.

AndreSait commented 1 year ago

In flutter 3.7.8, the onWillPop creates some casting problems, which can be fixed by changing it to this:

onWillPop: !widget.handleAndroidBackButtonPress && widget.onWillPop != null ? () async { final result = await widget.onWillPop!(_contextList[_controller!.index]); return Future.value(result); }

pupubird commented 11 months ago

Please help to merge this PR :c

pupubird commented 7 months ago

For anyone ever come to this issue, here's the V2 that's actively maintained https://pub.dev/packages/persistent_bottom_nav_bar_v2