search

Bildungsportal / moodle-local_table_sql

GNU General Public License v3.0
1 stars 0 forks source link

Namespace check #5

Open lostrogit opened 1 month ago

lostrogit commented 1 month ago

Please see https://moodledev.io/general/community/plugincontribution/checklist#namespace-collisions

rschrenk commented 1 month ago

could you please submit more information?

mudrd8mz commented 1 month ago

I believe your plugin violates https://moodledev.io/general/development/policies/codingstyle#rules-for-level2 - the "demo" namespace is not allowed here. If you insist on having it, it needs to be

namespace local_table_sql\local\demo;

and moved one folder deeper.

danmarsden commented 1 month ago

also classes like "class \delivery_table" violate the frankenstyle naming guidelines. it should also be namespaced within local_table_sql