search

Bildungsportal / moodle-local_table_sql

GNU General Public License v3.0
1 stars 0 forks source link

code seems to include MIT licensed react code? #8

Closed danmarsden closed 3 months ago

danmarsden commented 3 months ago

including other libraries copied from other locations is ok if the license associated complies with GPL, but you also need to include a thirdpartylibs.xml file that details this and what licence it uses.

More information on this is here: https://moodledev.io/docs/apis/commonfiles#thirdpartylibsxml And here: https://moodledev.io/general/community/plugincontribution/thirdpartylibraries

One of the other advantages of using this is that Moodle's codechecker automatically ignores any files included in the location specificed in the thirdpartylibs.xml file.

Please note - this is typically a blocker for approval in the plugins db.

danmarsden commented 3 months ago

ah - looks like you've partially covered this in: https://github.com/Bildungsportal/moodle-local_table_sql/blob/main/LICENSE.js.txt

but just missing the thirdpartylibs.xml file.

rschrenk commented 3 months ago

We added the thirdpartylibs.xml to the current release. It will move to the Moodle plugins database once we publish an incremented version.