search

Bilka2 / AbandonedRuins

"The Ruins Mod" is a mod for the game Factorio that adds factory ruins to the map.
https://mods.factorio.com/mod/AbandonedRuins
MIT License
9 stars 8 forks source link

Crashes on Load-in with Factory Inspector #29

Closed ErisAnn closed 2 years ago

ErisAnn commented 2 years ago

If I have the Factory Inspector mod enabled, I consistently crash on load-in with the error below.

Thank you for your time!!

The mod The Ruins Mod (1.1.6) caused a non-recoverable error. Please report this error to the mod author.

Error while running event AbandonedRuins::on_tick (ID 0) The mod Factory Inspector (1.1.9) caused a non-recoverable error. Please report this error to the mod author.

Error while running event factory-inspector::script_raised_built (ID 79) factory-inspector/script/event-handlers.lua:7: attempt to index field 'created_entity' (a nil value) stack traceback: factory-inspector/script/event-handlers.lua:7: in function <factory-inspector/script/event-handlers.lua:6> stack traceback: [C]: in function 'create_entity' AbandonedRuins/spawning.lua:45: in function 'spawn_entity' AbandonedRuins/spawning.lua:94: in function 'spawn_entities' AbandonedRuins/spawning.lua:172: in function 'spawn_ruin' AbandonedRuins/spawning.lua:184: in function 'spawn_random_ruin' AbandonedRuins/control.lua:58: in function <AbandonedRuins/control.lua:53>

image

Edit: Forgot to include full mod list for troubleshooting in case it isn't the Factory Inspector's fault: https://i.imgur.com/m8nRZFp.png

Bilka2 commented 2 years ago

Hey, this is a bug in the factory inspector mod. There is already a pull request with a solution: https://github.com/Aurensar/factorio-factoryinspector/pull/1. You could locally apply those changes to factory inspector to continue playing with both mods.

ErisAnn commented 2 years ago

Hey, this is a bug in the factory inspector mod. There is already a pull request with a solution: Aurensar/factorio-factoryinspector#1. You could locally apply those changes to factory inspector to continue playing with both mods.

omg I love you; I'm sorry I didn't see it. Thank you for the quick reply!!

jocker-il commented 2 months ago

seems it is still pending inclusion since december '23, not sure if the author of FactoryInspector even noticed it, but it's now incompatible with his latest build (1.1.25) and no mention of "AbandonedRuins" in the changelog.txt...

image

Bilka2 commented 2 months ago

There is no factory inspector 1.1.25 on the mod portal or on github, where are you getting the build from?

Bilka2 commented 2 months ago

In fact, looking at the factory inspector code on github, it should work without problems in 1.1.24: https://github.com/Aurensar/factorio-factoryinspector/blob/b8fff2c39169a65b8dd5138cacdecf9b0143ea79/script/event-handlers.lua#L7

jocker-il commented 2 months ago

I saw a reference to 1.1.25 in the change log,

I can't program that well so I guess he fixed it, if you say it's ok - you're the expert, an ex-Wube employee, if I'm not mistaken ?

Bilka2 commented 2 months ago

Hey, as I said based on the code on github, factory inspector 1.1.24 should work. If there is a problem with that version of the mod or a newer version of it, please link the version and the give error.

(I am still a Wube employee.)