Bilka2 / AbandonedRuins

"The Ruins Mod" is a mod for the game Factorio that adds factory ruins to the map.
https://mods.factorio.com/mod/AbandonedRuins
MIT License
9 stars 8 forks source link

Calls surface.set_tiles with an empty array of tiles #35

Open SGZ-Creations opened 1 year ago

SGZ-Creations commented 1 year ago
The mod The Ruins Mod (1.1.6) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event AbandonedRuins::on_tick (ID 0)
The mod NiceFill (0.1.20) caused a non-recoverable error.
Please report this error to the mod author.

Error while running event nicefill-scriptfix::script_raised_set_tiles (ID 83)
__nicefill-scriptfix__/control.lua:370: attempt to index field '?' (a nil value)
stack traceback:
    __nicefill-scriptfix__/control.lua:370: in function <__nicefill-scriptfix__/control.lua:366>
stack traceback:
    [C]: in function 'set_tiles'
    __AbandonedRuins__/spawning.lua:117: in function 'spawn_tiles'
    __AbandonedRuins__/spawning.lua:173: in function 'spawn_ruin'
    __AbandonedRuins__/spawning.lua:184: in function 'spawn_random_ruin'
    __AbandonedRuins__/control.lua:58: in function <__AbandonedRuins__/control.lua:53>

https://mods.factorio.com/mod/nicefill-scriptfix

SGZ-Creations commented 1 year ago

https://mods.factorio.com/mod/nicefill-scriptfix/discussion/647834eb7c2758fd385546c2

SGZ-Creations commented 1 year ago

space-exploration_0.6.108.zip SE-Recipe-Tweaker_0.0.4.zip Custom mod(s) needed https://cdn.discordapp.com/attachments/697564090415054858/1115178567035277323/1.1.57-1_Advanced_K2SE.zip

Bilka2 commented 1 year ago

Looks AbandonedRuins is doing a surface.set_tiles with an empty tiles array and the nicefill-scriptfix mod doesn't handle the resulting event having an empty tiles array. I'd consider it a bug on both sides - this mod for doing a useless call, the other mod for not handling a valid event.

SGZ-Creations commented 1 year ago

well it's reported on both sides too as the link tells

Bilka2 commented 1 year ago

Yeah, just sharing the results of my investigation.

Note for self: The array is empty because none of the tiles in the ruin exist as prototypes, due to SE or Alien Biomes or whatever.