Fix cpp preprocessor short circuit compatibility issue

Bill-Gray / find_orb

Orbit determination from observations

https://www.projectpluto.com/find_orb.htm

GNU General Public License v2.0

98 stars 45 forks source link

Fix cpp preprocessor short circuit compatibility issue #31

Closed NicolePV closed 3 years ago

NicolePV commented 3 years ago

Hello, Tried to make find_orb and had a small glitch because of short circuited notation in preprocessor macros. With this small change the build completed successfully. Thanks for the package!

Nicole

find_orb/make failed on CentOS Linux release 7.9.2009 gcc version 4.8.5 20150623 (Red Hat 4.8.5-44) (GCC) https://gcc.gnu.org/onlinedocs/cpp/_005f_005fhas_005finclude.html

getstrex.c:13:53: error: missing binary operator before token "(" && __has_include( <ncursesw/cursesw.h>)

Bill-Gray commented 3 years ago

Well, that's interesting... thank you; I've similar code in other packages, probably causing trouble for gcc-4.8 users. It's not an issue on later versions of gcc, nor on clang or MinGW or MSVC, which is why I didn't know about it.

gcc-4.8 is still getting use here and there; I'm a little surprised not to have heard before about this. I'm quite confident it's been causing people trouble.