BillGoldsmith / iOS-bugfest

0 stars 0 forks source link

💿(b47): bad metadata on an Etta James track #109

Closed bradtchapman closed 1 year ago

bradtchapman commented 1 year ago

Description of Issue:

An Etta James track that played recently shows an album release year of "2000" in the song info, but "1974" in the simple mode, and neither of these has the right album art anyway.

"Leave Your Hat On" was track 16:

https://www.discogs.com/release/3465869-Etta-James-The-Best-Of-Etta-James

This needs a review by multiple parties, possibly including your new sound guru, Joshua, if he is reviewing the catalogue metadata.

The sole reason I am filing this here is because the app pulled a date of 1974. Etta James did release an album that year, but not this one.

3030E5B0-41A2-490F-8A0D-390560D3CBAB

3CD92B28-9AD1-43C6-BD3F-90B49D14BF2F

RPNate1 commented 1 year ago

This is being dealt with outside the app. We are building a tool to interface with MusicBrainz where we will be getting all of the metadata for all the music (most of it comes from there now already). Every once in a while we get results like this and will be having an actual person reviewing the data in the near future.

bradtchapman commented 1 year ago

@RPNate1 @jarro @donshefer: your master database may have multiple fields correlating to the album title and year. There may be an internal field for the date when @BillGoldsmith added the tracks to the database. It's possible that an intermediary function—perhaps the API?—is editing the data in flight.

For example, the album "Out of Time" (1991) by R.E.M. has two spellings, depending on which API requests it. Gapless spells it with Title Case ("Out Of Time"), while the site API spells it with the articles in lowercase ("Out of Time").

https://api.radioparadise.com/api/gapless?bitrate=2&C_user_id=43154&event=2414221&source=7&numSongs=5&player_id=46C3F79B-8613-4273-A5D2-FB8036E9C0EB&chan=0
[...]
album = "Out Of Time"
year = "1991"
[...]

https://api.radioparadise.com/siteapi.php?file=music%3A%3Asong&withWiki=true&song_id=34318
[...]
    "album": "Out of Time",
    "album_release_year": "1991",
    "release_date": "1991-03-08",
[...]

.

Albums that were already entered with Title Case, such as "Dragon New Warm Mountain I Believe In You" by Big Thief, appear correct in the iOS app and also in the song info viewer on the web. (@BillGoldsmith's preamble to "Change" was very touching, btw).

One popular Gotye album has 4 songs in rotation. All four tracks in RP have the correct "album_release_year," but three of them show "2004" in the search field for "year."

Incidentally, the various APIs return three different fields with a "year" in them:

/api/gapless: album and year

/siteapi.php: album_id, album, release_date, album_release_year, and release_date.

I don't know which of these, if any, corresponds to the date when Bill added the song to Radio Paradise.

Song IDs: 39752, 39989, 40018, 40019. All four have a release date of "2006-05-21" but when you search for this album, three tracks come up with "2004." Only "Heart's A Mess" is correct.

{
            "song_id": "40019",
            "artist": "Gotye",
            "title": "Puzzle With A Piece Missing",
            "year": "2004",
            "duration": 332499,
            "album": "Like Drawing Blood",
            "user_rating": 0,
            "rating": 7,
            "cover_art": "covers\/l\/B000FS9940.jpg",
            "event_id": 2414220,
            "gapless_url": "https:\/\/audio-geo.radioparadise.com\/audio\/gapless\/0\/2\/2414220.m4a",
            "slideshow": [
                "17670",
                "17669",
                "57317",
                "17667",
                "17665",
                "41464",
                "43120",
                "11778",
                "58025",
                "43882",
                "17671",
                "17668",
                "16249",
                "49254",
                "31861",
                "31165",
                "66758",
                "44092",
                "66017",
                "52071",
                "8521",
                "52356",
                "73675",
                "43912",
                "72063",
                "70293",
                "43315",
                "72443",
                "64924",
                "37979",
                "60323",
                "73948",
                "21044",
                "46696",
                "72006"
            ],
            "cue": 0,
            "type": "M",
            "timeout_millis": 2700000,
            "sched_time_millis": 1679956823144,
            "ratings_num": 2386,
            "ratings_dist": [
                37,
                27,
                58,
                62,
                97,
                281,
                870,
                660,
                179,
                114
            ]
        },
jarro commented 1 year ago

This is a known issue, we are in the process of overhauling the music library.