search

BillGoldsmith / iOS-bugfest

0 stars 0 forks source link

[BUG] b62 offline listening tries to load data while in Airplane mode, resulting in repeated network error messages #132

Closed bradtchapman closed 1 year ago

bradtchapman commented 1 year ago

Brief description of the issue:

When starting an offline block from Airplane mode—or engaging Airplane mode while listening to an existing offline block—the RP app displays connection error modal alerts. This is inappropriate for a mode designed for offline listening.

It appears the app is trying to load the lyrics and comments. These must be fetched while the block is being generated, not after. OR, you need to warn users that Lyrics and Comments are unavailable while listening offline. I do believe you intended for this data to be available and portable with the offline block, though I can't comment on the legality of saving lyrics to an ephemeral cache.

Steps to reproduce:

  1. Create an offline block in the Download manager.
  2. Engage Airplane mode.
  3. Tap to play the block.
  4. You will see an error message immediately.

Alternatively: switch steps 2-3, then skip a song. You'll receive an error message also.

Expected result:

Offline mode should pre-cache everything and not try to fetch data.

Actual result:

Offline mode fetched data unexpectedly.

Where did you see it? (App build version, device type and iOS version): b61, iOS 16.4.1, iPhone 12 Pro.

(Please provide screenshots or error message text when possible.)

With pleasure!

IMG_4308

https://github.com/BillGoldsmith/iOS-bugfest/assets/32527656/28a2f67d-3db3-430e-ac1d-f681f9e6b343

RPNate1 commented 1 year ago

Lyrics and comments should be cached, not fetched.

RPNate1 commented 1 year ago

This appears to be fixed. b62

bradtchapman commented 1 year ago

This is not fixed in b62.

Warning appears after the first song. The download manager needs to cache lyrics and comments for ALL songs.

See attached screen recording.

bradtchapman commented 1 year ago

Recording attached.

https://github.com/BillGoldsmith/iOS-bugfest/assets/32527656/121e3fc8-83b4-455d-bcf4-30553e28bb84

RPNate1 commented 1 year ago

The lyrics and comments should be pre-loaded. @donshefer take a look at what's happening here.

donshefer commented 1 year ago

Now caching lyrics and comments with songs. Updated in build 68

RPNate1 commented 1 year ago

fixed b71