search

BillGoldsmith / iOS-bugfest

0 stars 0 forks source link

[Bug] Tap album art to show artist unexpectedly works while playing an offline block #287

Closed bradtchapman closed 1 year ago

bradtchapman commented 1 year ago

Brief description of the issue:

Build 1008 adds a tap on the album art to show details about the artist. Should this function be disabled while playing an offline block to avoid showing "An internet connection is required" to the end user?

Steps to reproduce:

  1. Download a block of music.
  2. Play it.
  3. Set the device to airplane mode.
  4. Tap the album art.

Expected result:

Any function that ordinarily requires internet access should be disabled when playing offline.

Where did you see it? (App build version, device type and iOS version):

Build 1008, iPhone 12 Pro

(Where possible, please attach Please provide screenshots or error message text)

RPNate1 commented 1 year ago

Yes. It should be disabled

On Fri, Aug 18, 2023 at 8:05 AM bradtchapman @.***> wrote:

Brief description of the issue:

Build 1008 adds a tap on the album art to show details about the artist. Should this function be disabled while playing an offline block to avoid showing "An internet connection is required" to the end user? Steps to reproduce:

  1. Download a block of music.
  2. Play it.
  3. Set the device to airplane mode.
  4. Tap the album art.

Expected result:

Any function that ordinarily requires internet access should be disabled when playing offline. Where did you see it? (App build version, device type and iOS version):

Build 1008, iPhone 12 Pro

(Where possible, please attach Please provide screenshots or error message text)

— Reply to this email directly, view it on GitHub https://github.com/BillGoldsmith/iOS-bugfest/issues/287, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5OMCY6QYPQJGFCFBDYOQXTXV6AE3ANCNFSM6AAAAAA3VU6Q7E . You are receiving this because you were assigned.Message ID: @.***>

-- __ Nate Adams Radio Paradise

“Art is how we decorate space, music is how we decorate time.” – Jean-Michel Basquiat http://radioparadise.com

ChristianNoc commented 1 year ago

Mh what’s so bad with that message, it just says no network connection? It’s exactly the same when tapping on the rating heart, tap on the „Artist name“ and tap on „album cover“, „slide show“ and so on in case you have no network connection. In my opinion it’s just a useful information for the user (In this case I would really call it a feature lol). An other option would be to Hide the buttons when offline, but without any information? I wouldn’t do that. And how should that work. Checking permanently if offline or not?

Even with a preloaded block I can be online and just use the downloaded block to save data and then I want definitely the buttons to be active. Or on and off when on the road because of mobile coverage. We discussed exactly that use case earlier.

@RPNate1 I remember another post where it was said the all buttons should be visible even when you are offline because of a decision from William (maybe my understanding was wrong).

RPNate1 commented 1 year ago

You are correct, now thinking about it. The message is fine.

On Fri, Aug 18, 2023 at 9:51 AM Christian Novotny @.***> wrote:

Mh what’s so bad on that message, it just says no network connection? It’s the same when tapping on the rating heart, tap on the „Artist name“ and tap on „album cover“, „slide show“ and so on. In my opinion it’s just a useful information for the user (I would really call it a feature lol). An other option would be to Hide the buttons when offline, but without any information? I wouldn’t do that. And how should that work. Checking permanently if offline or not? Even with a preload block I can be online and just use the downloaded block to save data and then I want definitely the buttons to be active.

@RPNate1 https://github.com/RPNate1 I remember another post where it was said the all buttons should be visible even when you are online because of a decision from William (maybe my understanding was wrong).

— Reply to this email directly, view it on GitHub https://github.com/BillGoldsmith/iOS-bugfest/issues/287#issuecomment-1684182385, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5OMCY654CUQLJXHAVTYAWDXV6MQXANCNFSM6AAAAAA3VU6Q7E . You are receiving this because you were mentioned.Message ID: @.***>

donshefer commented 1 year ago

@RPNate1 So, nothing to do for this?

RPNate1 commented 1 year ago

No

On Mon, Aug 21, 2023 at 3:25 AM Don Shefer @.***> wrote:

@RPNate1 https://github.com/RPNate1 So, nothing to do for this?

— Reply to this email directly, view it on GitHub https://github.com/BillGoldsmith/iOS-bugfest/issues/287#issuecomment-1686061594, or unsubscribe https://github.com/notifications/unsubscribe-auth/A5OMCY533CE2UYRP3XDYSTTXWMZQFANCNFSM6AAAAAA3VU6Q7E . You are receiving this because you were mentioned.Message ID: @.***>

-- __ Nate Adams Radio Paradise

“Art is how we decorate space, music is how we decorate time.” – Jean-Michel Basquiat http://radioparadise.com