BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
369 stars 99 forks source link

get_ncaa_schedule_info() returns the "RPI Ranking" Header as score and inning data... #208

Closed supernole1 closed 3 years ago

supernole1 commented 3 years ago

Only for years 2019-2021. Works fine for 2018 and beyond... image

BillPetti commented 3 years ago

Thanks for finding this. This should be fixed, reinstall baseballr and give it a try.

TravisRPetersen commented 3 years ago

I'm getting an error for get_ncaa_schedule_info after installing baseballr_0.8.5

get_ncaa_schedule_info(529, 2021)

Warning message: “Expected 3 pieces. Missing pieces filled withNAin 53 rows [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, ...].” Error: Can't recycle..1(size 57) to match..2` (size 51). Traceback:

  1. get_ncaa_schedule_info(529, 2021)
  2. game_result %>% filter(result != "Ppd") %>% bind_cols(game_info_url[, . c(2, 3)]) %>% select(row, slug, game_info_url)
  3. select(., row, slug, game_info_url)
  4. bind_cols(., game_info_url[, c(2, 3)])
  5. vec_cbind(!!!dots, .name_repair = .name_repair)
  6. stop_incompatible_size(x = .Primitive("quote")(structure(list(

`

supernole1 commented 3 years ago

This worked. thank you for the response and fix!

saiemgilani commented 3 years ago

This will be fixed/was fixed with the most recent PR's #230