BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
369 stars 99 forks source link

Issue with get_pbp_mlb from 2008-2009 #233

Open gdrod12 opened 2 years ago

gdrod12 commented 2 years ago

Describe the bug The get_pbp_mlb function works perfectly from 2010-2021, but it doesn't work for 2008-2009.

To Reproduce get_pbp_mlb(244438)

Expected behavior This should pull up an Orioles game from April 24th 2009. Instead, it gives the error "Join columns must be present in data. Problem with endTime." I'm very sure this isn't an issue of me not updating (unlike last time with scrape savant) because it has happened on two separate computers and the function works fine outside of 2008-2009. The get_game_pks_mlb function also works fine, just not get_pbp_mlb

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

BillPetti commented 2 years ago

Generally the current function works with games from 2010-present. This will take some time to fix as the columns used to join some of the underlying data don't exist prior to 2010.