BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
369 stars 99 forks source link

Missing column "barrel" statcast_search_pitchers #245

Closed zivoderjm closed 2 years ago

zivoderjm commented 2 years ago

Is your feature request related to a problem? Please describe. In previous versions of baseballr, this function pulled in 93 columns. I noticed that the column "barrel" is no longer included based on previous files that I have saved in the past.

To Reproduce test <- baseballr::statcast_search_pitchers("2021-04-01", "2021-10-03", 642547)

Describe the solution you'd like I was hoping that the original 93 columns would be pulled that includes the now missing column called "barrel".

saiemgilani commented 2 years ago

So that's my doing. I really didn't know people were using that column like that. You can create the column by running the dataframe through the function code_barrel(df)

I'll probably just add it back to the output on next release

zivoderjm commented 2 years ago

Thanks for the response! Totally understand and appreciate all that you guys do with this package.

I tried the new function and it says hit_angle is not found. I can look into the function and just see how barrel is calculated and do it simply myself.

Thanks again

On Tue, Mar 1, 2022, 11:44 AM Saiem Gilani @.***> wrote:

So that's my doing. I really didn't know people were using that column like that. You can create the column by running the dataframe through the function code_barrel(df)

— Reply to this email directly, view it on GitHub https://github.com/BillPetti/baseballr/issues/245#issuecomment-1055638504, or unsubscribe https://github.com/notifications/unsubscribe-auth/AFLYE6APMPPFSLSWBPGXS6TU5ZCNPANCNFSM5PURW2VQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

saiemgilani commented 2 years ago

Erg. Yeah I dunno. I will dig into it soonish

BillPetti commented 2 years ago

They changed their column labeling at some point and the function didn't get updated. hit_angle and hit_speed need to have 'hit' swapped for 'launch' and it will work