League standings not appearing for given date

BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.

billpetti.github.io/baseballr

Other

365 stars 99 forks source link

League standings not appearing for given date #253

Open metsfan2 opened 2 years ago

metsfan2 commented 2 years ago

Using the code below, I am trying to get the National League standings on June 13, 1957:

bref_standings_on_date("1957-06-13", "NL Overall", from = FALSE)

Expected behavior I expect to see output with this data and more:

Instead, this is the output I am getting:

Desktop

Device: [MacBook Pro]
OS: [MacOS Monterrey, v. 12.3.1]
Browser [Safari]
Version [15.4]

BillPetti commented 2 years ago

Appears to be an issue from 1968 back. 1969 was the first year they went to divisions within each league. The underlying html and tables are fundamentally different pre-1969, so we'll need a fix.

camdenk commented 2 years ago

Since the function is built for the current league structure (three divisions in each league), there'll be small inaccuracies every year pre-1994, but not necessarily outright errors unless trying to pull some of the AL standings.