BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
367 stars 100 forks source link

mlb_player_game_stats() #259

Closed thaydye closed 2 years ago

thaydye commented 2 years ago

Hi,

When I run the mlb_player_game_stats() function, it returns a tibble with all the column names in the first column. There must be a syntax error. See attached picture.

image

Describe the bug A clear and concise description of what the bug is.

To Reproduce Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

BillPetti commented 2 years ago

Can you provide a reproducible example of the error please?

saiemgilani commented 2 years ago

https://billpetti.github.io/baseballr/reference/mlb_player_game_stats.html

mlb_player_game_stats(person_id = 605151, game_pk = 531368)

No idea what's going on here but will look into it

saiemgilani commented 2 years ago

And by that I meant, thank you @thaydye it has been fixed on the master branch, retry installing from GitHub and you'll be good