search

BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
367 stars 100 forks source link

playerid_lookup returning a 404 #309

Closed jtrain907 closed 1 year ago

jtrain907 commented 1 year ago

When attempting to use the function 'playerid_lookup' I am getting a 404 error.

Here is my command line: 

library(baseballr)
playerid_lookup("Goldschmidt", "Paul")

This returns the following rather than a dataframe of player id codes as expected: 

 [100%] Downloaded 14 bytes...
Error in curl::curl_download(input, tmpFile, mode = "wb", quiet = !showProgress) : 
  HTTP error 404.
jtrain907 commented 1 year ago

This appears to have been fixed.

camdenk commented 1 year ago

I was unable to recreate the error on my local machine.

Did you change anything since trying it a few days ago that could've explained the fix or was it likely a one-off failure? I know we had to change some of the chadwick functions earlier this year to match their new file structure.

jtrain907 commented 1 year ago

I'm thinking likely a one-off. It was reproducible on both of my machines which is why I thought it was more than a single-system issue, but perhaps both systems were impacted by some sort of similar caching issue. I clean installed baseballr and it worked after that.