search

BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
356 stars 98 forks source link

attempt at Chadwick installation checks; #307 #311

Closed beanumber closed 7 months ago

beanumber commented 10 months ago

Grateful for feedback on this PR for #307 !

saiemgilani commented 7 months ago

I'm not really sure if this does work but we will try it on main and get it fixed if there are issues once we really check it

closes #307

beanumber commented 6 months ago

FYI, we are hoping to send the book to the publisher next week. This function is currently not included in the book. (See https://beanumber.github.io/abdwr3e/A_retrosheet.html#sec-chadwick for a function with similar functionality.) However, that could be changed (but only before next week).

saiemgilani commented 6 months ago

It's included on the main branch and will be included in the CRAN version assuming the function doesn't get flagged by CRAN for not meeting some requirements

beanumber commented 6 months ago

OK, sounds good! Thanks!