search

BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
367 stars 100 forks source link

ncaa_game_logs not working for type = "pitching" #336

Open kylemckelvey16 opened 4 months ago

kylemckelvey16 commented 4 months ago

I have been running game by game data pulls using the following code all year long for both batting and pitching types and just this week, pitching stopped working as expected.

The error it gives me when I run any player_id is "Invalid arguments provided", but I haven't changed any of the arguments that were working all season long, and batting works with the same arguments.

test1 <- ncaa_game_logs(player_id = "2522072", year = 2024, type = "pitching", span = "game") test2 <- ncaa_game_logs(player_id = "2522072", year = 2024, type = "batting", span = "game")

I expect the output for that to be a dataframe with NAs in the blank cells that I filter out later, but now it's just coming through as blank and it gives me the error I mentioned above.

saiemgilani commented 4 months ago

will look into it

rdavtian commented 4 months ago

@saiemgilani Seems like a similar issue occurs for fg_pitchers_leaders or fg_pitch_leaders function as well when I tried running it yesterday. fg_bats_leaders works as well.