search

BillPetti / baseballr

A package written for R focused on baseball analysis. Currently in development.
billpetti.github.io/baseballr
Other
367 stars 100 forks source link

`ncaa_teams` function returns `NA` for every `team_id` #341

Open hedgertronic opened 3 months ago

hedgertronic commented 3 months ago

Describe the bug The ncaa_teams function returns NA for every team_id.

To Reproduce Run the following function call: ncaa_teams(year = 2024, division = 1)

I get the following in return:

   team_id team_name  team_url conference_id conference division  year season_id
   <chr>   <chr>      <chr>    <chr>         <chr>         <dbl> <dbl> <chr>    
 1 NA      Charlotte  /teams/… 823           AAC               1  2024 NA       
 2 NA      East Caro… /teams/… 823           AAC               1  2024 NA       
 3 NA      Fla. Atla… /teams/… 823           AAC               1  2024 NA       
 4 NA      Memphis    /teams/… 823           AAC               1  2024 NA       
 5 NA      Rice       /teams/… 823           AAC               1  2024 NA 
...

Expected behavior That the team_id field contains the valid team ID. I want to pass this ID into ncaa_rosters.

statstew commented 3 months ago

I am getting the same behavior but wasn't a couple weeks ago. Additionally, when I load in the successful ncaa_teams data from earlier in the season and try to call the get_ncaa_schedule_info() function, I am getting a bunch of 0 row data frames.