search

Billingegroup / bg-mpl-stylesheets

Matplotlib style sheets
Other
4 stars 27 forks source link

fixed hex color in color cycler #14

Closed yevgenyr closed 3 years ago

yevgenyr commented 3 years ago

@sbillinge , there was an error in the last color - merge to fix.

yevgenyr commented 3 years ago

@sbillinge there was an error with the color cycler - the last color was wrong - too many "b0"

sbillinge commented 3 years ago

@dragonyanglong please could you check this and see what Yevgeny's color looks like? Maybe we can add it to the color example plot and compare the two colors. It is either a typo in the original or it is ok but it will be easier to figure that out by looking at the two colors and see which makes more sense in the cycle. Thanks so much.

dragonyanglong commented 3 years ago

HI @yevgenyr , can you please send me your color cycles? The hex codes. @sbillinge would like to compare the colors.

dragonyanglong commented 3 years ago

oh never mind, I grab the color cycle in this PR. @sbillinge , I think it looks exactly the same. Basically, Yev helped fixed a typo in the original color cycle.

Original: ['#0B3C5D', '#B82601', '#1c6b0a', '#328CC1', '#a8b6c1', '#D9B310', '#984B43', '#76323F', '#626E60', '#AB987A', '#C09F80', '#b0b0b0ff']

Yev's PR: ['0B3C5D', 'B82601', '1c6b0a', '328CC1', 'a8b6c1','D9B310', '984B43', '76323F', '626E60', 'AB987A', 'C09F80', 'b0b0ff']

Basically, the last one '#b0b0b0ff' was a typo, and he helped correct it into 'b0b0ff'

BTW, @yevgenyr , I guess we need a "#" in the cycle map?

sbillinge commented 3 years ago

This I understand, but in your color cycle plot you are plotting the typo one and it looks good....or am I missing something? So I would like to see both the colors just to make sure we have everything correct.

S

On Tue, Nov 3, 2020 at 8:49 AM longyang notifications@github.com wrote:

oh never mind, I grab the color cycle in this PR. @sbillinge https://github.com/sbillinge , I think it looks exactly the same. Basically, Yev helped fixed a typo in the original color cycle.

Original: ['#0B3C5D', '#B82601', '#1c6b0a', '#328CC1', '#a8b6c1', '#D9B310', '#984B43', '#76323F', '#626E60', '#AB987A', '#C09F80', '#b0b0b0ff']

Yev's PR: ['0B3C5D', 'B82601', '1c6b0a', '328CC1', 'a8b6c1','D9B310', '984B43', '76323F', '626E60', 'AB987A', 'C09F80', 'b0b0ff']

Basically, the last one '#b0b0b0ff' was a typo, and he helped correct it into 'b0b0ff'

BTW, @yevgenyr https://github.com/yevgenyr , I guess we need a "#" in the cycle map?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721126574, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUIN4JH3M57ECI4OAG3SOADAFANCNFSM4TG6OS2A .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

dragonyanglong commented 3 years ago

image I see. I think they are exactly the same, maybe matplotlib sometime auto translate it into the correct hex code (6 letters), because it doesn't give me any error when plot. You can see my plot here.

sbillinge commented 3 years ago

ok. Let's go with Yevgeny's fix then. Not rely on matplotlib to do the right thing.....thanks Yevgeny. Just let me know if and when I should merge Yevgeny's PR, or if Long needs to put one in for some reason and I close Yevgeny's

S

On Tue, Nov 3, 2020 at 9:57 AM longyang notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/16789768/98000690-c3247100-1dba-11eb-81b7-afc315361645.png I see. I think they are exactly the same, maybe matplotlib sometime auto translate it into the correct hex code (6 letters), because it doesn't give me any error when plot. You can see my plot here.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721174510, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUMN4T6ROIPEBQ34UETSOAK4NANCNFSM4TG6OS2A .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

dragonyanglong commented 3 years ago

I think it would be easier for me create a new PR to fix the hex code and update the example color map plot in readme. I suggest close this PR, and merge my PR (to be pushed in a few mins)

dragonyanglong commented 3 years ago

Oh wait... sorry... I just tried to plot the correct hex code first, then plot our old one. and it seems like the color do change... not sure what is going on. but it seems like the color is getting blue,and the old hex code simply just copy the last color somehow

dragonyanglong commented 3 years ago

image

ok I found an error in my earlier plot code, sorry, I updated the plot, please take a look. maybe hex code doesn't have to be 6 letters...

sbillinge commented 3 years ago

we should also check if hte typo is the ff, so the correct hex is b0b0b0 not b0b0ff

On Tue, Nov 3, 2020 at 10:24 AM longyang notifications@github.com wrote:

Oh wait... sorry... I just tried to plot the correct hex code first, then plot our old one. and it seems like the color do change... not sure what is going on. but it seems like the color is getting blue,and the old hex code simply just copy the last color somehow

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721196635, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUOBZ7MAV2SID2BY6Y3SOAOEJANCNFSM4TG6OS2A .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

dragonyanglong commented 3 years ago

image

sbillinge commented 3 years ago

yes, personally I wouldn't pick that purple.... :)

On Tue, Nov 3, 2020 at 10:27 AM longyang notifications@github.com wrote:

[image: image] https://user-images.githubusercontent.com/16789768/98005358-f0731e00-1dbe-11eb-8314-cd6287bc08cd.png

ok I found an error in my earlier plot code, sorry, I updated the plot, please take a look. maybe hex code doesn't have to be 6 letters...

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721198246, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUOSD6X4XGMTUWH3MHTSOAON3ANCNFSM4TG6OS2A .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

dragonyanglong commented 3 years ago

image

sure, I included all the three hex here. b0b0ff, b0b0b0ff, and b0b0b0, the latter two give the same color in matplotlib

dragonyanglong commented 3 years ago

Ok sure, so let me remove the last ff, so the correct hex code would be b0b0b0. I will make a PR.

sbillinge commented 3 years ago

I expect that the color code just takes the first-6 of the hex code if it is longer, which would explain the behavior. But better to have it right.

S

On Tue, Nov 3, 2020 at 10:32 AM longyang notifications@github.com wrote:

Ok sure, so let me remove the last ff, so the correct hex code would be b0b0b0. I will make a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721201691, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUKZU3PFIVHNLW2TU5TSOAPCBANCNFSM4TG6OS2A .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

yevgenyr commented 3 years ago

wow... Sorry for the mess ... X_X I simply could not find the b0b0b0ff color code in libreoffice so I thought there is an extra 'b0' ... but you have figured it out.

Thanks !

On Tue, Nov 3, 2020 at 10:37 AM Simon Billinge notifications@github.com wrote:

I expect that the color code just takes the first-6 of the hex code if it is longer, which would explain the behavior. But better to have it right.

S

On Tue, Nov 3, 2020 at 10:32 AM longyang notifications@github.com wrote:

Ok sure, so let me remove the last ff, so the correct hex code would be b0b0b0. I will make a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721201691 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABAOWUKZU3PFIVHNLW2TU5TSOAPCBANCNFSM4TG6OS2A

.

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721204483, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMGCZIA4BCUTNN6MIHQIVYLSOAPSZANCNFSM4TG6OS2A .

-- Yevgeny Rakita, PhD Data Science Institute

with the Department of Applied Physics and Applied Mathematics / Materials Science and Engineering program Columbia University

sbillinge commented 3 years ago

no apologies!!!! you found a bug and together we squashed it!!!! Entropy of the universe went down :) That is what coding is all about.....reduce entropy! That thing was there ready to bite us in the future, now not.

On Tue, Nov 3, 2020 at 11:35 AM Yevgeny Rakita notifications@github.com wrote:

wow... Sorry for the mess ... X_X I simply could not find the b0b0b0ff color code in libreoffice so I thought there is an extra 'b0' ... but you have figured it out.

Thanks !

On Tue, Nov 3, 2020 at 10:37 AM Simon Billinge notifications@github.com wrote:

I expect that the color code just takes the first-6 of the hex code if it is longer, which would explain the behavior. But better to have it right.

S

On Tue, Nov 3, 2020 at 10:32 AM longyang notifications@github.com wrote:

Ok sure, so let me remove the last ff, so the correct hex code would be b0b0b0. I will make a PR.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <

https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721201691

, or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABAOWUKZU3PFIVHNLW2TU5TSOAPCBANCNFSM4TG6OS2A

.

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub < https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721204483 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/AMGCZIA4BCUTNN6MIHQIVYLSOAPSZANCNFSM4TG6OS2A

.

-- Yevgeny Rakita, PhD Data Science Institute

with the Department of Applied Physics and Applied Mathematics / Materials Science and Engineering program Columbia University

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/mpl-stylesheets/pull/14#issuecomment-721239619, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUIISNZOMSXW3HLGMLLSOAWMTANCNFSM4TG6OS2A .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

sbillinge commented 3 years ago

closed by #14