search

Billingegroup / cookiecutter

A cookie-cutter for DiffPy packages.
Other
1 stars 8 forks source link

change on push workflow to be a matrix over all supported python versions #109

Closed sbillinge closed 4 hours ago

sbillinge commented 2 months ago

Only do this on push to main for pure python packages.

bobleesj commented 1 month ago

@Tieqiong Since it's a part of the milestone, will be this implemented after

https://github.com/Billingegroup/cookiecutter/pull/123

?

Tieqiong commented 1 month ago

A matrix test workflow is mostly ok, but could be tricky for small things, even for pure python packages.

For example, for Mac platform there's no up to date, usable version of pdffit2 on conda forge, which means for a matrix test we need to specifically ask macOS to uninstall diffpy.pdffit2 (if installed), install gsl, then pip install pdffit2 (see diffpy/diffpy.pdfgui#205).

I can try to write one, but further fixing is going to be needed for sure.

bobleesj commented 1 month ago

Okay, since our current priority is testing the central CI system (#115), let's re-visit this as soon as we are done with it.

sbillinge commented 1 month ago

We can just have the matrix so what doesn't break to begin with. Let's discuss.

bobleesj commented 3 weeks ago

Can be closed with the new PR https://github.com/Billingegroup/release-scripts/pull/51

bobleesj commented 5 hours ago

@sbillinge Could you please close this issue?