search

Billingegroup / cookiecutter

A cookie-cutter for DiffPy packages.
Other
1 stars 8 forks source link

Update pyproject.toml, remove setup.py #33

Closed 8bitsam closed 2 months ago

8bitsam commented 2 months ago

Closes #7 Replaces setup.py in package root dir with pyproject.toml.

sbillinge commented 2 months ago

please could you redo this PR on a clean main? thnks so much.... Sorry for the hassles.

8bitsam commented 2 months ago

I think it should be otherwise up to date with main now.

sbillinge commented 2 months ago

yes, but there is a dirty merge of main. Normally, never merge main unless there is a good reason to. We do it the other way around (we merge the branches into main).

So just close this PR and make a new one from a clean main. There has been a bunch of cleaning going on which is one reason this is happening.

S

On Wed, Jun 19, 2024 at 5:41 PM Sam Andrello @.***> wrote:

I think it should be otherwise up to date with main now.

— Reply to this email directly, view it on GitHub https://github.com/Billingegroup/cookiecutter/pull/33#issuecomment-2179489117, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUKNF3Z6TKWHKTQHKBDZIH3HVAVCNFSM6AAAAABJSMNOTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGQ4DSMJRG4 . You are receiving this because you commented.Message ID: @.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University

8bitsam commented 2 months ago

Alright, will do this for my other PR too.

sbillinge commented 2 months ago

yes, thanks. git hygiene.....

On Wed, Jun 19, 2024 at 6:05 PM Sam Andrello @.***> wrote:

Alright, will do this for my other PR too.

— Reply to this email directly, view it on GitHub https://github.com/Billingegroup/cookiecutter/pull/33#issuecomment-2179508926, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUIGTBVAQ5MOXVN427TZIH6CRAVCNFSM6AAAAABJSMNOTOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGUYDQOJSGY . You are receiving this because you commented.Message ID: @.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University