Update pre-commit-config.yaml

[sbillinge]

closes #9

[sbillinge]

Git diff check:

[sbillinge]

per @Sparks29032 comment in the issue, changing the name to .yml from .yaml prevents cookiecutter from finding it. it may be fixable, but I suggest it is not worth the bother. Let's stick with yaml.

[Sparks29032]

Got it! Merge? Seems good

[sbillinge]

Yes, I'm good to merge this.

How can we trigger pre-commit in the CI on the cookiecutter repo? Do we want to do that? I don't think there are any other tests we want to run on CI

[Sparks29032]

I think I put in a request to add the CI for pre-commit (not sure where that request goes though), but yea, matches with the original repo probably mean the pre-commit operations are done

[sbillinge]

the ci wasn't in the pre-commit until this PR, so maybe it runs on later ones after we merge this one......?

On Wed, Jun 19, 2024 at 3:20 PM Sparky @.***> wrote:

I think I put in a request to add the CI for pre-commit (not sure where that request goes though), but yea, matches with the original repo probably mean the pre-commit operations are done

— Reply to this email directly, view it on GitHub https://github.com/Billingegroup/cookiecutter/pull/36#issuecomment-2179345541, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUJKK5J45VLMEKUEXLTZIHKZBAVCNFSM6AAAAABJSSOXD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGM2DKNJUGE . You are receiving this because you authored the thread.Message ID: @.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University

[Sparks29032]

I think you have to do something in the project settings maybe to enable it since I didn't have permissions to add it, just to send in a request

It could be at this link?

[Sparks29032]

pre-commit.ci run

[sbillinge]

OK, I will merge this to get the changes and we can work on getting it to pass other things.