Billingegroup / cookiecutter

A cookie-cutter for DiffPy packages.
Other
1 stars 8 forks source link

ci #38

Closed sbillinge closed 2 months ago

sbillinge commented 2 months ago
sbillinge commented 2 months ago

@Sparks29032 I am basically stumped onthis. I can't get either flake8 nor black to exclude {{ cookiecutter.repo_name }}/doc/source/conf.py and {{ cookiecutter.repo_name }}/setup.py whatever I tried. Evan chatgpt failed me. Don't spend too much time on it, it is probably not worth it, but quite frustrating.....

Sparks29032 commented 2 months ago

Oh, add **/conf.py and **/setup.py to --exclude

There is an issue with reading the double brackets I believe. I think this worked for me, let me check.

I messed up my git head, so I am reconfiguring right now

Sparks29032 commented 2 months ago

I am going to push a commit through to this branch in a bit I think it should resolve.

Also, instead of excluding setup.py, can we add cookiecutter to --builtins to fix the setup.py errors?

sbillinge commented 2 months ago

yes, please modify as you see fit. the **/setup.py worked in .flake8 but I couldn't get black to ignore the conf.py file, but do whichever fix you like.

sbillinge commented 2 months ago

I merged changes to the readme and a branch with test_utils.py and together these should allow people to run tests against diffpy.utils files. I am getting weird pexpect errors when I try and run test_utils.py locally so I have some issue with my env I think, but hopefully it can work for others.

This will make it way easier to review everything

Sparks29032 commented 2 months ago

You may have to install pexpect as the thing to automatically generate the cookie-cut repo seems to use pexpect.

sbillinge commented 2 months ago

I have pexpect installed, but I get a pexpect.spawn AttributeError so there is some other pexpect overloaded somehow.....

On Wed, Jun 19, 2024 at 6:01 PM Sparky @.***> wrote:

You may have to install pexpect as the thing https://github.com/Billingegroup/cookiecutter/pull/37/files to automatically generate the cookie-cut repo seems to use pexpect.

— Reply to this email directly, view it on GitHub https://github.com/Billingegroup/cookiecutter/pull/38#issuecomment-2179505675, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUJHMSEB7Z2SDJNLV6LZIH5TDAVCNFSM6AAAAABJSUQGOOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNZZGUYDKNRXGU . You are receiving this because you authored the thread.Message ID: @.***>

-- Simon Billinge Professor, Department of Applied Physics and Applied Mathematics Columbia University

Sparks29032 commented 2 months ago

FINALLY

Sparks29032 commented 2 months ago

I have pexpect installed, but I get a pexpect.spawn AttributeError so there is some other pexpect overloaded somehow.....

Dang, I'll see if it pops up when running on my end

sbillinge commented 2 months ago

wow @Sparks29032 thanks so much, nicely done there!