Closed Sparks29032 closed 3 weeks ago
full_name is used:
In that case we don't need to ask this question any more...
email is used:
In which case we don't need to ask this question?
github_username is used:
github_org
in there not username
Summary: We need a question github_org that we don't have atm (except in this PR) but we don't actually need a question for github_username
I think the others are all fine as they are, though we can make it less confusing for people if we ask fewer questions because we are sticking to conventions of building directory names from package names and so on.
Got it, that makes sense
Okay, so I will remove email (and have made a comment in the setup.py
issue about changing to your email). I also agree that github_username can be removed. I will keep full_name (refactored to github_org) as it will also be used to link to the contributor graph.
can we also get it down to just one question for package_name? Are there any edge cases where we will not use package_name for directory names and so on?
Not sure, it probably is there to ensure proper naming conventions for the package (for pip installation) and some command line commands that do not allow for spaces within names.
I want to at least keep dist name as maybe we want to release programs in the diffpy package without the diffpy.
proceeding it. Not sure if this will ever happen, but maybe good to keep in case.
New header in __init__.py
with contributors.
Can we merge this? I want to get the name change asap as the header files in all other .py
files require github_org
for the contributors.
Do not change the workflow files as it is not using the cookiecutter
full_name
but the GitHubfull_name
.Closes #40 as all other names seem fine.