search

Billingegroup / cookiecutter

A cookie-cutter for DiffPy packages.
Other
0 stars 7 forks source link

Change .codecov to be consistent with diffpy.utils's #44

Closed stevenhua0320 closed 3 weeks ago

stevenhua0320 commented 3 weeks ago

Closes #15 Initial commit to make .codecov consistent with diffpy.utils Update if_ci_failed from 'failure' to 'error' in coverage since it reports only has 'error' or 'success' options.

截屏2024-06-20 下午11 49 07
sbillinge commented 3 weeks ago

@Sparks29032 please can you check the failure vs error issue. I am not sure I understand Steven's comment.

@stevenhua0320 after @Sparks29032 checks it, if it is broken in diffpy.utils we will need an issue (and a PR to fix it) in diffpy.utils. If it is not broken in diffpy.utils, we can update this PR to keep them consistent.

Thanks for flagging this!

Sparks29032 commented 3 weeks ago

Interesting, failure and ignore were deprecated 2 years ago. Let us change it to error, thanks!

sbillinge commented 3 weeks ago

great! Nice work @stevenhua0320 !

@stevenhua0320 , please can you open an issue (and preferrably a PR) on diffpy.utils to fix it there.

I will merge this.