Closed 8bitsam closed 3 months ago
Can you change exclude
to [ "{{ cookiecutter.project_name}}.tests*" ]
. The include
change is probably fine as we would likely need another post_gen
hook to properly fix it up.
This is the latest git diff
, for reference:
This is the latest
git diff
, for reference:
Thanks for this. Getting there. Questions:
keywords
keyword? - [Simon] yes, maybe with a reasonable default. We need to understand what they are used for to make better keywords{{ cookiecutter.github_org }}
or {{ cookiecutter.package_name }}
or something.@sbillinge To answer your questions: 1) I agree, I think the user could provide a number of keywords (maybe max 3 to keep it from being bloated) when they call cookiecutter. 2) No industry standard that I know of, but it's prob just easier to change it here since it doesn't really matter. 3) There's the case that some diffpy packages might not have a diffpy directory so I think we should keep it default. It shouldn't change anything afaik.
@sbillinge To answer your questions:
1. I agree, I think the user could provide a number of keywords (maybe max 3 to keep it from being bloated) when they call cookiecutter. 2. No industry standard that I know of, but it's prob just easier to change it here since it doesn't really matter. 3. There's the case that some diffpy packages might not have a diffpy directory so I think we should keep it default. It shouldn't change anything afaik.
sounds good.
@8bitsam we need to remove the conflict.
@sbillinge Should be able to merge fine now.
@8bitsam @sbillinge I think we need to change the cookiecutter.full_name into something else in pyproject.toml. I pulled this and can't cut anymore because of it.
@8bitsam @sbillinge I think we need to change the cookiecutter.full_name into something else in pyproject.toml. I pulled this and can't cut anymore because of it.
Yes, we definitely do. I already re-opened pyproject.toml
to address this.
Closes #7 See
git diff
screenshot (--- is old, +++ is new):