search

Billingegroup / cookiecutter

A cookie-cutter for DiffPy packages.
Other
1 stars 8 forks source link

Replace source code: <package>/ __init__.py and version.py #50

Closed Tieqiong closed 3 months ago

Tieqiong commented 3 months ago

fix #22 fix #23 replace #46

sbillinge commented 3 months ago

@Tieqiong this looks good. It would be nice if we could get it to pass pre-commit.ci. @Sparks29032 and I fought with this yesterday for conf.py so we should be able to find a solution here too.

Sparks29032 commented 3 months ago

@Tieqiong can you do a git diff and paste the result here? Once confirmed, seems good to merge!

Tieqiong commented 3 months ago
Screenshot 2024-06-21 at 7 16 40 PM Screenshot 2024-06-21 at 7 15 08 PM
Sparks29032 commented 3 months ago

@sbillinge There does not seem to be a PEP standard for newlines within triple quotes. The example given in the PEP specification has the triple quotes all in one line as @Tieqiong has currently, which is not done in diffpy.utils.

image

sbillinge commented 3 months ago

@sbillinge There does not seem to be a PEP standard for newlines within triple quotes. The example given in the PEP specification has the triple quotes all in one line as @Tieqiong has currently, which is not done in diffpy.utils.

image

I think I am ok with either way.