search

Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 73 forks source link

jumana IDs and URL #307

Closed jc-umana closed 4 years ago

jc-umana commented 4 years ago

I added my GitHub ID, ORCID ID, and Google Scholar URL to people.yml

sbillinge commented 4 years ago

Thanks for this @jc-umana

This seems to be failing CI. Here is what to do when that happens:

  1. you can see what the fail is by clicking on the tiny Details link in the continuous-integration/travis-ci/pr part of the "All checks have failed" place above. it is a validation error
  2. you can run the failing test locally. In a terminal go to rg-db-group/local directory and type regolith validate
  3. make changes to your entries in the database locally and rerun the tests till they pass
  4. git add, git commit, git push
  5. wait for Travis to run to see if tests are now passing
jc-umana commented 4 years ago

Thanks for this @jc-umana

This seems to be failing CI. Here is what to do when that happens:

  1. you can see what the fail is by clicking on the tiny Details link in the continuous-integration/travis-ci/pr part of the "All checks have failed" place above. it is a validation error

  2. you can run the failing test locally. In a terminal go to rg-db-group/local directory and type regolith validate

  3. make changes to your entries in the database locally and rerun the tests till they pass

  4. git add, git commit, git push

  5. wait for Travis to run to see if tests are now passing

Hey, Professor Billinge! Thanks for getting back to me on this. I’ve been trying all morning, and the tests have kept failing. Regolith doesn’t seem to want to get through the regolith validate command. I will try again, following your instructions to the letter. Wish me luck!

sbillinge commented 4 years ago

see if you can figure it out, but get back to me if you can't and I will tell you.....

On Tue, Jun 16, 2020 at 6:42 AM jc-umana notifications@github.com wrote:

Thanks for this @jc-umana https://github.com/jc-umana

This seems to be failing CI. Here is what to do when that happens:

1.

you can see what the fail is by clicking on the tiny Details link in the continuous-integration/travis-ci/pr part of the "All checks have failed" place above. it is a validation error 2.

you can run the failing test locally. In a terminal go to rg-db-group/local directory and type regolith validate 3.

make changes to your entries in the database locally and rerun the tests till they pass 4.

git add, git commit, git push 5.

wait for Travis to run to see if tests are now passing

Hey, Professor Billinge! Thanks for getting back to me on this. I’ve been trying all morning, and the tests have kept failing. Regolith doesn’t seem to want to get through the regolith validate command. I will try again, following your instructions to the letter. Wish me luck!

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/307#issuecomment-644685041, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUJ3VCUKLEOZ7EEDFJ3RW5ECPANCNFSM4N7OOFRQ .

-- Professor Simon Billinge Columbia University

sbillinge commented 4 years ago

Jaylyn you don' tneed to keep closing these PRs. Just make a fix and push it to the same PR.

On Tue, Jun 16, 2020 at 7:00 AM jc-umana notifications@github.com wrote:

Closed #307 https://github.com/Billingegroup/rg-db-public/pull/307.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/307#event-3448427421, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUI57MBX3N4BPRGMEHTRW5GFHANCNFSM4N7OOFRQ .

-- Professor Simon Billinge Columbia University

jc-umana commented 4 years ago

What's the most efficient way to do this? I've just kept doing that because I was afraid of exacerbating the problem.

On Tue, Jun 16, 2020 at 7:06 AM Simon Billinge notifications@github.com wrote:

Jaylyn you don' tneed to keep closing these PRs. Just make a fix and push it to the same PR.

On Tue, Jun 16, 2020 at 7:00 AM jc-umana notifications@github.com wrote:

Closed #307 https://github.com/Billingegroup/rg-db-public/pull/307.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub <https://github.com/Billingegroup/rg-db-public/pull/307#event-3448427421 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/ABAOWUI57MBX3N4BPRGMEHTRW5GFHANCNFSM4N7OOFRQ

.

-- Professor Simon Billinge Columbia University

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/307#issuecomment-644695070, or unsubscribe https://github.com/notifications/unsubscribe-auth/APG2XFUZQ3OQTAP47XGW24TRW5GZ7ANCNFSM4N7OOFRQ .

sbillinge commented 4 years ago

just keep pushing until you hear me yell "let's close this PR and start over". I do that when you do a merge into your branch locally and push it up, so as long as you don't do that....

On Tue, Jun 16, 2020 at 7:13 AM jc-umana notifications@github.com wrote:

What's the most efficient way to do this? I've just kept doing that because I was afraid of exacerbating the problem.

On Tue, Jun 16, 2020 at 7:06 AM Simon Billinge notifications@github.com wrote:

Jaylyn you don' tneed to keep closing these PRs. Just make a fix and push it to the same PR.

On Tue, Jun 16, 2020 at 7:00 AM jc-umana notifications@github.com wrote:

Closed #307 https://github.com/Billingegroup/rg-db-public/pull/307.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub < https://github.com/Billingegroup/rg-db-public/pull/307#event-3448427421 , or unsubscribe <

https://github.com/notifications/unsubscribe-auth/ABAOWUI57MBX3N4BPRGMEHTRW5GFHANCNFSM4N7OOFRQ

.

-- Professor Simon Billinge Columbia University

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/Billingegroup/rg-db-public/pull/307#issuecomment-644695070 , or unsubscribe < https://github.com/notifications/unsubscribe-auth/APG2XFUZQ3OQTAP47XGW24TRW5GZ7ANCNFSM4N7OOFRQ

.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/307#issuecomment-644698347, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUMY4OVGOL2DA3BHYE3RW5HVFANCNFSM4N7OOFRQ .

-- Professor Simon Billinge Columbia University