Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 73 forks source link

Mto paper published #350

Closed dragonyanglong closed 3 years ago

dragonyanglong commented 3 years ago

@sbillinge , Please review and merge.

BTW, I also updated a few published info about the PDFitc paper citation in the same PR.

dragonyanglong commented 3 years ago

Thanks Simon. I pushed the edits. For Acta A paper, I couldn't find the page numbers.

https://journals.iucr.org/a/issues/2021/01/00/ae5091/index.html

sbillinge commented 3 years ago

Thanks Long. They won't appear until the edition is published I guess. Please leave that milestone open for now so we don't overlook it when it is done.

On Wed, Dec 16, 2020 at 9:40 PM longyang notifications@github.com wrote:

Thanks Simon. I pushed the edits. For Acta A paper, I couldn't find the page numbers.

https://journals.iucr.org/a/issues/2021/01/00/ae5091/index.html

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/350#issuecomment-747166943, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUPKFPVFLHOC54F56ULSVFVTHANCNFSM4U3ZVIMA .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

dragonyanglong commented 3 years ago

Hi @sbillinge , I added the final publication info. I also rebased the branch to resolve the conflicts. Please review and merge.

dragonyanglong commented 3 years ago

Hi Simon, I did a quick test, using note = '' and optnote='' to generate two publication list pdf separately. I didn't quite see a difference between them. I screenshot them below.

  1. note = ``: image

  2. optnote=``: image

dragonyanglong commented 3 years ago

I saw that some people usually use optnote to specify the arxiv entry (if any), for example, in my MgTi2O4 paper, yang;prb20 entry, I did so. So I guess here we use note to specify status like submitted or to be published etc. and optnote for arxiv? Since I always copy the template from old entries, not sure if it is what you want.

sbillinge commented 3 years ago

optnote is just a way of corrupting note. In Bibtex you can include any keys you want, but it will only use keys it knows when it builds the bibliographic entry. It knows note so it puts it somewhere in there when it builds (before something and after something according to the style). It doesn't know optnote so it just ignores it. the question was whether everything typeset correctly when note was set to an empty string and the answer is yes, so that is fine. If we want to retain some information, such as the arxiv reference, but don't want it to appear when the item is typeset we just have to "corrupt" the note-field to any non-recognized key, but opt is used conventionally, implying that it can be used optionally, (by deleting the opt). If you see what I mean.

S

On Tue, Jan 5, 2021 at 10:40 AM longyang notifications@github.com wrote:

I saw that some people usually use optnote to specify the arxiv entry (if any), for example, in my MgTi2O4 paper, yang;prb20 entry, I did so. So I guess here we use note to specify status like submitted or to be published etc. and optnote for arxiv? Since I always copy the template from old entries, not sure if it is what you want.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/350#issuecomment-754714297, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUPCTAA2UML2SW5KOYDSYMXGXANCNFSM4U3ZVIMA .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

dragonyanglong commented 3 years ago

Oh I see, thanks Simon!

sbillinge commented 3 years ago

@dragonyanglong this seems to be failing ci now.

sbillinge commented 3 years ago

CI was just stuck....then it finished ok so I merged. Thanks Long!

dragonyanglong commented 3 years ago

Got it. Thanks Simon!