search

Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 71 forks source link

closing onboarding #358

Closed lkranis closed 3 years ago

lkranis commented 3 years ago

Closing Onboarding take II. I hopefully did it correctly this time.

sbillinge commented 3 years ago

I think that fix is right, but the commit doesn't seem to be in the right branch and it is still failing CI. Did you make the change in your local and then push to your fork (that is the right workflow)

lkranis commented 3 years ago

I believe so. When I go to push it to the origin I get "Everything up-to-date", not sure if thats the correct output.

sbillinge commented 3 years ago

@lkranis maybe a quick call with me or someone else can sort this out. These challenges are common when you start using git. It is complicated (but powerful) and takes some getting used to.

lkranis commented 3 years ago

Yes that sounds like a good idea. What time works for you ?

sbillinge commented 3 years ago

please look at my calendar, pick a 30 min open slot and send a calendar invite....I will accept it.

S

S

On Fri, Jan 8, 2021 at 11:24 AM lkranis notifications@github.com wrote:

Yes that sounds like a good idea. What time works for you ?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/358#issuecomment-756850895, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAOWUKGKHQGLDMTFII5T53SY4WTHANCNFSM4VZM2JUA .

-- Simon Billinge Professor, Columbia University Physicist, Brookhaven National Laboratory

sbillinge commented 3 years ago

replacing this PR with new PR #363