search

Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 71 forks source link

Yevgeny updated people #362

Closed yevgenyr closed 3 years ago

yevgenyr commented 3 years ago

Updated my personal info in People db

sbillinge commented 3 years ago

Thanks so much for this @yevgenyr. I will have to modify regolith to accept the linked_in ID in the schema, but I can do that quickly then it should pass CI.... It is a good addition.

sbillinge commented 3 years ago

Close and reopen to trigger CI after modifying regolith

sbillinge commented 3 years ago

It looks as if there is still an issue with the entry:

could not find expected ':'

  in "../db/people.yml", line 4083, column 3
yevgenyr commented 3 years ago

please try now. added double quotes and fixed typo. I left linkedin. Let me know if it is better to remove it for now and add when things are ready to host it

sbillinge commented 3 years ago

Thanks @yevgenyr I will merge like this.

I see from the deleted part that the problem was just an indentation problem. The text from line 2 onwards should have been indented a further two whitespaces. No quotes etc. were actually needed, but I think it is fine as is (the html is building but I haven't looked how it renders).