search

Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 73 forks source link

updated information on people for cbullard #400

Closed chloeann95 closed 3 years ago

chloeann95 commented 3 years ago

I'm not sure if that's the correct way to add a 2nd line for a 2nd degree, if it's not let me know.

chloeann95 commented 3 years ago

PDL is only on Wednesday so I planned on attending today. What do you mean by carriage in the first comment?

On Mon, Aug 2, 2021 at 9:27 AM Simon Billinge @.***> wrote:

@.**** commented on this pull request.

super! I left a couple of comments inline.

Can you make the group checkin in a few minutes or do you have PD training?

In db/people.yml https://github.com/Billingegroup/rg-db-public/pull/400#discussion_r680966708 :

@@ -464,22 +464,40 @@ cbullard:

active: true

aka: []

avatar: https://github.com/chloeann95.png

  • bio: bio

  • education: []

  • email: @.***

  • bio: Chloë grew up in Michigan and attended Michigan State University for her undergraduate degrees in Physics and Mechanical Engineering, where she worked on computational plasma physics research. Afterward she attended the University of Toledo completing a Masters in Chemical Engineering while working on modeling CFD simulations for biomass with NREL. When not working you can find her looking for a new game to play or a new song to learn on the piano.$

no blank line here. Also, please put in carriage returns every ~80 characters for the bio.

In db/people.yml https://github.com/Billingegroup/rg-db-public/pull/400#discussion_r680969553 :

employment:

 - begin_date: 2021-07-26

   end_date: 2022-12-31

   organization: columbiau

  • position: masters researcher

  • position: Masters Researcher

This is ok. If the lower case version renders all lower case, we should change the builder to use title-case. It is better to have the app handle the casing in general. Summary: leave this, but note to selves, let's check the website that all the positions appear correctly whatever case they have in the db.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Billingegroup/rg-db-public/pull/400#pullrequestreview-720196738, or unsubscribe https://github.com/notifications/unsubscribe-auth/AQG6XW6STAQX36GZMFHLT7DT22MNHANCNFSM5BMVCN2A .

chloeann95 commented 3 years ago

Understood and addressed comments.