search

Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 71 forks source link

DOC: finished Adeolu Ajayi profile on people.yml #518

Closed aajayi-21 closed 1 year ago

sbillinge commented 1 year ago

@aajayi-21 gentle ping on this. I can't close your rg-db-group PR until this one merges because in that PR you say that you finished this task, but this task is only finished when it merges.

Reach out if you have questions.

sbillinge commented 1 year ago

@aajayi-21 gentle ping on this. Please see my review. Make sure your notifications are set up so you see these, but I usually respond quickly.

The branch is conflicted. To fix this, don't close this branch, but....

  1. check out main
  2. sync main with upstream
  3. check out finishing_my_profle branch
  4. Using pycharm (recommended) or otherwise, merge main into finishing_my_profile
  5. push to this PR by pushing to your origin. git push should work if you linked your local correctly

I will receive a notification and can check and merge. For education, just put your undergrad degree (with expected graduation date)

sbillinge commented 1 year ago

@aajayi-21 I'm closing this. I think it is out of date and there are lots of issues there. Please can you check your entry in people.yml and make sure it is ok. Now you are expert in forking workflow it will be a 2 minute job to fix it if anything needs fixing (usually bio and education fields)

aajayi-21 commented 1 year ago

I will check and update it if there are any issues