search

Billingegroup / rg-db-public

Public Research Group Database
BSD 2-Clause "Simplified" License
1 stars 73 forks source link

Modify to people #527

Closed EngrIbrahimAdnan closed 1 year ago

EngrIbrahimAdnan commented 1 year ago

I have created another branch specifying it is an iadnan modification, NOT addition to People.yml, per your instructions.

EngrIbrahimAdnan commented 1 year ago

Thank you for your feedback, Simon.

Please don't add a new iadnan, only one is allowed in the db. Work from the existing one that passes all the tests and just add things basically, but resist modifying or deleting what is there currently. The info is used to build reports and websites and if it doesn't follow the schema they won't build.

I'll keep in mind everything you said. I will make sure to refrain from deleting anything and only use false when the field isn't applicable. I have deleted the other iadnan. I was not aware it even existed.

Please don't remove/update the employment entry for the group/Columbia. This is how the reports find you as a group member. To add your work with the Kuwait ministry, copy-paste the fields from the existing employment entry and change the values but don't add or remove any fields

I am not entirely sure I am supposed to do anything here. Am I supposed to update my work experience in group/Columbia are am I not supposed to? Please let me know.

I will revisit this later. Right now I prefer to start on the ML-edex project since there is a deadline to be met.

sbillinge commented 1 year ago

@EngrIbrahimAdnan sorry, I didn't see your question in there before now.

Basically the task is that there was already a database entry for you that was created by my program during the onboarding process. One field that was left open is one that looks like bio: bio. The first task is to delete the value bio and replace it with whatever text you want. This is used when we build reports and web-pages that uses this information so write whatever you might want, to. for example, here is what Songsheng wrote: https://billingegroup.github.io/people/sstao.html

The second task is to fill in your education section, which would follow the same pattern as the other ones you can find in the file. Put your undergrad degree as on item in the list and your current masters degree as the other item. Make sure it is valid yaml format and doesn't break the syntax.

sbillinge commented 1 year ago

Hi Ibrahim,

I am just going back and doing some cleaning. I found this. There are all kinds of issues here. I recommend that now you are a bit more familiar with the regolith databases and the github workflow it may be a good time to return to this. I will close this PR, but could you use the workflow to open a new PR and update your existing iadnan entry with bio and education? Thanks.