Billingegroup / staged-recipes-cookiecutter

Cookiecutter for uploading to conda-forge.
Other
1 stars 4 forks source link

Remove empty build section in meta.yaml #16

Closed bobleesj closed 2 months ago

bobleesj commented 2 months ago

As discussed here: https://github.com/Billingegroup/staged-recipes-cookiecutter/issues/13#issuecomment-2327322865

The latest cookiecutter version renders into:

requirements:
  build:

  host:
    - python >=3.10
    - setuptools
    - pip

  run:
    - python >=3.10
    - numpy

For projects that do not require dependencies under build, we could simply remove the build: ... section so that we can save the conda-recipe reviewer's and our time.

requirements:
  host:
    - python >=3.10
    - setuptools
    - pip

  run:
    - python >=3.10
    - numpy
sbillinge commented 2 months ago

I am not sure if this will save us time. Let's come to a consensus about the best way to handle this before implementing this.

bobleesj commented 2 months ago

My thought was that a reviewer may ask to remove the empty build section which can lead to another iteration. But not sure if the reviewer would.

sbillinge commented 2 months ago

It is a good thought but we would like the cookicutter to capture the most general behavior. It is easier to remove things we don't want than to add things that are needed in certain circumstances. We could add flags for the different situations that only adds this section when it is needed, but it adds complication

bobleesj commented 2 months ago

Noted on being careful with removing files. Since its not our priority I will close it