Billmate / opencart

Billmate payment plugin for opencart
BSD 2-Clause "Simplified" License
1 stars 3 forks source link

Unable to specify payment title for multi-language / multi-store #173

Open kryllem opened 7 years ago

kryllem commented 7 years ago

Payment titles are stored in model folder and not language. This causes problems with multilanguage/multistore solution.

Boxedsolutions commented 7 years ago

Can you explain this?

It should be this title that you need to translate for payment method title. https://github.com/Billmate/opencart/blob/master/catalog/language/swedish/payment/billmate_partpayment.php#L10

kryllem commented 7 years ago

Correct me if I am wrong but on those payment methods, payment title is stored in model config file and not language, and it is that one that is showing at checkout. Billmate bank, Billmate card, Billmate partpayment

Multistore means that all config files are shared with other store.

It could almost be the best way to move titles to admin backed so everybody could type what they want. And for another language, another title.

Boxedsolutions commented 7 years ago

It should use the titles in language folder. And append the description after the title. At least for bank and card. Will look into this in the next release so this is the case for invoice and partpayment also.

kryllem commented 7 years ago

The reason was: $_['text_title_name'] = '%s'; As you pointed.. So it seems to work after change %s to something else.

But still, it would be more friendly to have it moved to modules in backend

Boxedsolutions commented 7 years ago

The problem is if a store has, lets say 30 different languages. It would be a lot of fields.

My idea is that we could add a field in a separate the language file. For example billmate_custom.

The %s is used by sprintf and replaces the %s with different things as partpayment cost and so on.

kryllem commented 7 years ago

You could add a new tab in backend module like Languages. That would come up if multilanugage is in use.

Up to you.

For now, this is solved.

Thanks by the way!

Boxedsolutions commented 7 years ago

No problem, only happy if I can help.

kryllem commented 7 years ago

:smile: