search

Billmate / prestashop

Billmate payment plugin for Prestashop
BSD 2-Clause "Simplified" License
6 stars 8 forks source link

Starting checkout, then removing all items, will then redirect to a 500 error. #394

Closed OskarOstlund closed 3 years ago

OskarOstlund commented 3 years ago

Would you attempt to start a checkout then open up a new tab, empty your cart, and then finish the checkout will you get redirected to a 500 error page. Would you then try to make a new purchase will you instead be redirected to a new page that just say "ok" and the order will not be completed.

How to reproduce: 1: Start a purchase and go to the final step of the checkout. 2: Open up a new tab. 3: Go to the cart and remove all items so that your cart is entirely empty. 4: Go back to the original tab. 5: Finish the order. 6: Attempt to make a second order in this original tab.

andyjohansson commented 3 years ago

Edge case and I'm unsure how we can avoid this scenario. I however think that we can avoid this if we use the native way and not try to reinvvent the wheel. I.e. we stick to PrestaShop native orderconfirmation and so on. @OskarOstlund does the same behaviour occur if we use a built in payment method?

OskarOstlund commented 3 years ago

No error message, No rogue state, you are not even redirected to a successURL and are instead redirected to your order history and no order is created in the store.

andyjohansson commented 3 years ago

OK, then I think we need to take a look this one as well @KFoobar prior to the release of 3.8.

KFoobar commented 3 years ago

I can't reproduce this issue. I don't get a 500 error.

It may have already been resolved by a commit from the last few days.

@OskarOstlund Please verify if this still is an issue.

OskarOstlund commented 3 years ago

I still get the error but that is only on my localhost version so this seems to be bound to people developing locally which seems to be a very minor situation.

I doubt this is enough of an issue to justify holding back the release though. I assume you are of a similar mind @andyjohansson .

andyjohansson commented 3 years ago

Agree. Let's see if this error pops up later on.