BillyBlaze / OctoPrint-TouchUI

A touch friendly interface for a small TFT module or phone
https://billyblaze.github.io/OctoPrint-TouchUI/
GNU Affero General Public License v3.0
274 stars 92 forks source link

Fix for installing TouchUI when other plugins are already enabled. #513

Closed StrongbowTexas closed 3 years ago

StrongbowTexas commented 3 years ago

I kept running into this error during the installation (I was running the install in the directory of user "touchui", obviously:

/home/touchui/TouchUI-autostart/helpers/install-steps/6-setup-autologin-as: line 8: [: too many arguments

This error caused the touch screen on my Pi to try to load the UI, but just sat there at "Connecting to TouchUI".

Here's the fix. Apologies for not creating a fork, checking in my fix and creating a pull request, but I know just enough git to know what those words mean.

touchui@octopi:~/TouchUI-autostart $ git diff diff --git a/helpers/install-steps/6-setup-autologin-as b/helpers/install-steps/6-setup-autologin-as index 9d35efa..ca5b08a 100644 --- a/helpers/install-steps/6-setup-autologin-as +++ b/helpers/install-steps/6-setup-autologin-as @@ -1,8 +1,8 @@

!/bin/bash

source $DIR/functions/successfull

-OCTOPRINT_EXEC=$(ps -ef | grep octoprint | grep -v grep | awk '{print $9}') -OCTOPRINT_EXEC_USER=$(ps -ef | grep octoprint | grep -v grep | awk '{print $1}') +OCTOPRINT_EXEC=$(ps -ef | grep [o]ctoprint | grep "[s]erve\b" | awk '{ print $9 }') +OCTOPRINT_EXEC_USER=$(ps -ef | grep [o]ctoprint | grep "[s]erve\b" | awk '{ print $1 }')

echo "" if [ -z $OCTOPRINT_EXEC ]

github-actions[bot] commented 3 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

BillyBlaze commented 3 years ago

Thanks for reporting. Regardless what github-actions does I will fix this :+1:

github-actions[bot] commented 3 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.