search

BillyBlaze / OctoPrint-TouchUI

A touch friendly interface for a small TFT module or phone
https://billyblaze.github.io/OctoPrint-TouchUI/
GNU Affero General Public License v3.0
274 stars 92 forks source link

TouchUI fails to initialize when plugin replaces temperature tab #515

Closed sirinsidiator closed 2 years ago

sirinsidiator commented 2 years ago

I've installed https://github.com/jneilliii/OctoPrint-PlotlyTempGraph because it allows me to show an additional temperature sensor connected to the pi in the graph. The graph plugin seems to replace the div block for the graph tab with its own version with an id "tab_plugin_plotlytempgraph". Because of this the TouchUI fails to initialize and is completely unusable since it expects there to be a block with the id "temp" to clone certain elements to.

I've fixed this locally by replacing every mention of "#temp" with "#tab_plugin_plotlytempgraph" which seems to work fine for me. I'm not entirely sure how a proper fix would look like, but it would be nice if some solution could be found, so I do not have to reapply this change every time TouchUI receives an update in the future.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.