search

BillyBlaze / OctoPrint-TouchUI

A touch friendly interface for a small TFT module or phone
https://billyblaze.github.io/OctoPrint-TouchUI/
GNU Affero General Public License v3.0
274 stars 92 forks source link

Temp Graph in TouchUI 0.3.18 obscured after upgrade to Octoprint 1.8.0 #532

Closed MarkForrest closed 2 years ago

MarkForrest commented 2 years ago

Upgraded to Octoprint 1.8.0, using Raspberry Pi 4 plus official touchscreen in portrait orientation, temperature graph is shifted lower on screen so it can't be seen. Tried updating Raspberry Pi OS. Verified by doing fresh install of OctoPi 0.18 with Octoprint 1.8.1 Also forced TouchUI mode on laptop running recent Chromium and Firefox. On Firefox the graph isn't obscured but is pushed down the page

Only fixed by downgrading Octoprint back to 1.7.3 and temp graph was then corrected.

vexofp commented 2 years ago

I think the culprit here may be the new "wrench" menu button added in Octoprint 1.8.0 (the one that currently allows you to toggle "Show state marks"). It is implemented as a new div above the temperature graph. It looks like TouchUI is expecting the temperature graph to be div:first-child in that context, when it adjusts it to take up most of the screen. Now that first child is the button's row, instead, so we end up with the graph pushed down off the bottom.

github-actions[bot] commented 2 years ago

This issue has been automatically marked as inactive because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

MarkForrest commented 2 years ago

Thanks, I'll have a look and see if I can tweak the code to allow for the extra first div

LooLaBoo commented 2 years ago

Yes I was thinking the same thing that the culprit was the "new wrench". I'm interested to see your results MarkForrest. I'd have a try myself but i've not enough coding know how to make those kinds of edits. Good luck.

vexofp commented 2 years ago

Fixing the styling for Octoprint 1.8.x is fairly easy; here is a branch that does so. (Just changes the selector to the second child, instead of the first. I also made the new wrench button overlay on top of the graph, instead of wasting precious space above it.)

The catch is that this will break the layout for older Octoprint versions before 1.8. I am not sure how to gracefully handle both versions at the same time, unfortunately. @BillyBlaze Do we need to worry about such backwards compatibility, or is upping the required Octoprint version acceptable? (Or does anyone have a good idea how to handle both layouts?)

github-actions[bot] commented 2 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.