search

BillyBlaze / OctoPrint-TouchUI

A touch friendly interface for a small TFT module or phone
https://billyblaze.github.io/OctoPrint-TouchUI/
GNU Affero General Public License v3.0
274 stars 92 forks source link

suggestion: show warning if "gcode visualizer" is enabled #88

Closed gretel closed 7 years ago

gretel commented 7 years ago

this really seems to drag down slow machines when enabled therefore i suggest showing a collapsable warning or similar.

BillyBlaze commented 7 years ago

Thanks for the suggestion. We need to disable this plugin in touchscreen mode.

BillyBlaze commented 7 years ago

So, Yeah, I was also here confused with the plugin "STL Viewer".

In touchscreen mode, the default gcode viewer will already be disabled. See; https://github.com/BillyBlaze/OctoPrint-TouchUI/blob/master/source/js/components/touchscreen.js#L36

gretel commented 7 years ago

guess both ('gcode visualizer' and 'stl viewer') will impact performance and in relation to the size of the data. the latter one does not have a limiting option at the present time. i suggest thinking about how to let the backend handle the lesser requirements of alternative UIs - like not delivering heavy components at all.

BillyBlaze commented 7 years ago

Yeah, the latter is giving TouchUI a bit of an issue. I will definitely give a warning, or even better, disable STL viewer in touchscreen mode.

For now I have add'd this to checklist of #39

jstefanop commented 7 years ago

seems like the gcode visualizer is still loading with current version of octoprint (1.3.1). What is the easiest way to completely disable the visualizer on the local device (i still want it to load on other devices that load ocroprint, the pi just cant handle loading it locally on chromium).

BillyBlaze commented 7 years ago

Thanks, I can also confirm that the gcode visualizer currently loads in touchscreen mode.

I will fix this and make a new release.

BillyBlaze commented 7 years ago

This is fixed in the latest 0.3.6 release.

github-actions[bot] commented 4 years ago

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.