search

BillyCurtis / OpenSpotifySafariExtension

Displays an Open in Spotify alert for sideloaded Spotify App
123 stars 17 forks source link

EeveeSpotify 3.1 #3

Closed whoeevee closed 6 months ago

whoeevee commented 6 months ago

In version 3.1 of EeveeSpotify, I improved link support. OpenSpotifySafariExtension didn't work well and didn't work at all in some cases, such as with Spotify Jam links. I implemented SceneDelegate hook in the tweak. It hooks the openURLContexts method and calls continueUserActivity if the link is from OpenSpotifySafariExtension (see https://github.com/whoeevee/EeveeSpotify/commit/f1aababc452f99f9b77e8d8d171923516b973508). It works flawlessly with all links.

Yeah, it makes OpenSpotifySafariExtension compatible only with EeveeSpotify, but I believe EeveeSpotify is the only reason to use sideloaded Spotify now.

BillyCurtis commented 6 months ago

I don’t really use Spotify anymore so I didn’t know about Jam links.

Since I’m not at home I’m unable to check this but does EeveeSpotify support links that include the language code in the url? see issue #2

whoeevee commented 6 months ago

Yes, it basically opens links just like the official app opens applinks. I just tested the case in the issue and set iOS language to Portuguese, it works.

BillyCurtis commented 6 months ago

Okay, I'll merge the pull request